Opened 4 years ago

Closed 4 years ago

#3136 closed change (fixed)

Only show about:feedback to users that installed via Play and have ABB_RELEASE_BUILD set

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-1.1.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328791/

Description

Background

As of #2930, all users that installed via Google Play will see about:feedback, which asks them to rate the app. Users that installed the beta version from Google Play will, however, not be able to rate it. So we should not show it if it is a devbuild.

What to change

Only show about:feedback if ABB_RELEASE_BUILD is set.

Change History (5)

comment:1 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-1.1.0

comment:2 Changed 4 years ago by fhd

  • Milestone Adblock-Browser-for-Android-1.1.0 deleted

comment:3 Changed 4 years ago by fhd

  • Owner set to fhd

comment:4 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by fhd

  • Milestone set to Adblock-Browser-for-Android-1.1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.