Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3144 closed defect (fixed)

Can't use / (forward slash) when composing filter

Reported by: Gingerbread Man Assignee: trev
Priority: Unknown Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner, mapx, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328831/
https://codereview.adblockplus.org/29329848/

Description (last modified by greiner)

Environment

Firefox 41.0.1
Adblock Plus 2.6.11

Firefox 44.0a1 (2015-09-30)
Adblock Plus 2.6.11.3985-beta

How to reproduce

  1. Click the Adblock Plus icon and choose Filter Preferences.
  2. Click the Custom Filters tab.
  3. Click the Add Filter button.
  4. Type / on your keyboard.

Observed behavior

The Quick Find bar opens and filter composition is cancelled.

Expected behavior

The Quick Find bar shouldn't open and / should appear in the filter composition box.

Forum thread

https://adblockplus.org/forum/viewtopic.php?f=1&t=40709

What to change

Capture key presses in "filter-search.js" for the keys ' and /. Those are hardcoded in findbar.xml to trigger the Find As You Type (FAYT) functionality even if the accessibility.typeaheadfind preference is set to false.

Change History (8)

comment:1 Changed 3 years ago by mapx

  • Cc greiner mapx added

comment:2 Changed 3 years ago by greiner

  • Cc trev added
  • Description modified (diff)

Added "What to change" section to get this ticket to ready state.

comment:3 Changed 3 years ago by trev

  • Ready set

comment:4 Changed 3 years ago by greiner

  • Owner set to greiner

comment:5 Changed 3 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 years ago by trev

  • Owner changed from greiner to trev
  • Review URL(s) modified (diff)

Let's try a different approach.

comment:7 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by trev

  • Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox

Adblock Plus 2.6.12 is being released from branch, this change is part of it.

Note: See TracTickets for help on using tickets.