Opened 2 years ago

Closed 2 years ago

Last modified 23 months ago

#3153 closed defect (fixed)

Remove duplicated handling of add-subscription in Platform

Reported by: greiner Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-1.10.1-for-Chrome-Opera-Safari
Module: Platform Keywords: goodfirstbug
Cc: sebastian, mapx Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333133/

Description (last modified by sebastian)

Environment

Chrome 45
Adblock Plus 1.9.2.1481

How to reproduce

  1. Go to https://adblockplus.org/en/features#tracking
  2. Click on "open this dialog"

Observed behaviour

Options page is opened twice with only the second instance showing the confirmation dialog.

Expected behaviour

Options page is opened once and shows the confirmation dialog.

Background

With the dependency update in #3087 we integrated code from #1528 that includes opening the options page when the message responder receives the "add-subscription" event. This event, however, is already handled by the background page. This causes the options page to be opened twice whenever an abp:subscribe link is clicked.

What to change

Remove the handling of "add-subscription" in adblockpluschrome/background.js.

Change History (9)

comment:1 Changed 2 years ago by greiner

  • Cc sebastian added

comment:2 Changed 2 years ago by sebastian

  • Description modified (diff)
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 2 years ago by greiner

  • Owner set to greiner

comment:4 Changed 2 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by greiner

See also #3510

comment:6 Changed 2 years ago by mapx

  • Cc mapx added

comment:7 Changed 2 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 23 months ago by sebastian

  • Milestone set to Adblock-Plus-1.10.1-for-Chrome-Opera-Safari

comment:9 Changed 23 months ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

Done. The options page opens once when opening 'Open this dialog' from ​https://adblockplus.org/en/features#tracking.

Chrome 44,45,46
Adblock Plus 1.10.0.1534

Note: See TracTickets for help on using tickets.