Opened 18 months ago

Closed 14 months ago

Last modified 14 months ago

#3165 closed change (fixed)

As a user i want to be able to configure a whitelist

Reported by: sven Assignee: jand
Priority: P2 Milestone: Adblock-Plus-for-iOS-1.1.0
Module: Adblock-Plus-for-iOS Keywords: salsita 2015q4
Cc: jand, pavelz, vojtab, fhd, mario Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockplussafariios/pull/11

Description (last modified by sven)

Background

There is no way to add a whitelist in our content blocker yet.

What to change

  1. Create new menu item into the Adblock Plus settings called "Whitelisted Websites" with an arrow right icon (similar to Acceptable Ads)
  2. After clicking this menu item, you should see the "Whitelisted Websites" menu, which includes two categories "ADD WEBSITE TO WHITELIST" and "YOUR WHITELIST"

ADD WEBSITE TO WHITELIST
The default text "www.website.com" should be displayed in an input field. The color of this default text is #a1a1a1. On the right side there is a blue button (default iOS blue: R:0,G:122,B:255 or # 007aff) with a "+" in it. The "+" is written in Source Sans Pro Regular, size: 40px, #FFFFFF. The button width is 100px and the "+" is centered.

Workflow

  • After clicking the input field, the iOS keyboard appears and the default text "www.website.com" disappears. A cursor will be displayed instead of the default text.
  • After typing in a URL this could be confirmed by pressing the "return" or "Go" button on the keyboard or by pressing the blue "+" button.
  • If these steps are done, the URL will appear with a fade in animation. This animation should be from top to bottom and should push existent white listed URLs one item down. If it's the first whitelist item the "No websites added yet" item should fade out while the fade in animation of the new element should be the same as described before.In this special case the animations should start simultaneously.
  • The item includes the shortened URL (remove http://www.) and a remove icon. This icon should be aligned with the + button and be in a bounding box which is also 100px wide (icon should be centered in that bounding box). The remove icon itself is 22px wide and 25px high. A URL shouldn't be able to be added more than once. It should also not be possible to add the same URL with different lower/upper case letters. All letters of an URL should be written in lower case letters, when it's displayed in the whitelisted websites list.
  • The added website should be removed from the list and the system, after clicking the trash bin icon.
  • As soon as a website ("domain.tld" or "www.domain.tld" as well as subdomains) is added to the whitelist, ABP is inactive for this domain and thus doesn't block any ads. This is achieved by adding a white listing rule to ABP for the entered domain. (https://adblockplus.org/en/filters#whitelist)

Remove icon
Screenshot Adblock Plus settings
Screenshot Whitelisted Websites (default)
Screenshot Whitelisted Websites (with two items)

Attachments (5)

Adblock Plus iOS 12 whitelisted websites 1.png (105.2 KB) - added by sven 18 months ago.
Adblock Plus iOS 12 whitelisted websites 2-2.png (91.3 KB) - added by sven 18 months ago.
Adblock Plus iOS 12 whitelisted websites 3.png (91.8 KB) - added by sven 18 months ago.
delete_v1.png (18.9 KB) - added by sven 18 months ago.
Ticket_3165.png (18.0 KB) - added by lisabielik 18 months ago.

Download all attachments as: .zip

Change History (30)

Changed 18 months ago by sven

comment:1 Changed 18 months ago by sven

  • Description modified (diff)

comment:2 Changed 18 months ago by lisabielik

Please see Ticket_3165.png for text changes.

Changed 18 months ago by lisabielik

comment:3 Changed 18 months ago by vojtab

Just a note regarding the "No filterlist added yet" item:

1) the screenshots suggest this label should have form of an "menu item". This may be a bit confusing as the menu item is usually clickable element that have some action aligned to itself. Wouldn't it be better to show static label instead? Similarly to what is done already in Adblock Browser, when there are no whitelisted websites available.

2) the text "No filterlists added yet", while accurate, can again be a bit confusing. Wouldn't it be better to show just "No Websites Whitelisted" or similar to clearly indicate the current state?

comment:4 Changed 18 months ago by vojtab

3) I assume user should not be able to add same url twice? Should there be any feedback in UI if he/she attempts to do so, or should simply no item be added upon plus button click?

comment:5 Changed 18 months ago by sven

  • Description modified (diff)

comment:6 Changed 18 months ago by sven

Thanks for your feedback vojta.

1) We will use this method for the browser in the future as well. So please use the approach described in this ticket.
2) Thx! I changed the description.
3) Exactly, i also added some more words for this in the description.

comment:7 Changed 18 months ago by mario

  • Cc pavelz vojtab mario added
  • Priority changed from Unknown to P3
  • Ready set

comment:8 follow-up: Changed 18 months ago by philll

The description does not mention what should happen after a user entered a URL as described. I guess this should prevent ABP to be active there.

comment:9 in reply to: ↑ 8 Changed 18 months ago by mario

  • Description modified (diff)

Replying to philll:

The description does not mention what should happen after a user entered a URL as described. I guess this should prevent ABP to be active there.

Exactly. Added some more information to the description. However, @fhd is going to provide more insight.

comment:10 Changed 18 months ago by mario

  • Keywords salsita added

comment:11 Changed 17 months ago by mario

  • Milestone set to Adblock-Plus-for-iOS-1.1.0

comment:12 Changed 17 months ago by mario

  • Keywords 2015q4 added

comment:13 Changed 17 months ago by sven

  • Description modified (diff)

comment:14 Changed 17 months ago by jand

  • Review URL(s) modified (diff)

comment:15 Changed 17 months ago by mario

  • Priority changed from P3 to P2

Changed 2015q4-issues to P2

comment:16 Changed 16 months ago by fhd

  • Status changed from new to reviewing

comment:17 Changed 16 months ago by fhd

  • Owner set to jand

comment:18 Changed 16 months ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:19 Changed 14 months ago by scheer

What is the intended behaviour for removing whitelisted websites?


Can you confirm this is only for iOS 9.0 and above as the IPA displays on Hockey?

Last edited 14 months ago by scheer (previous) (diff)

comment:20 Changed 14 months ago by sven

  • Description modified (diff)

comment:21 Changed 14 months ago by scheer

What should be the observed behaviour if the user adds a variation of a website that is already in the Whitelist? As in, the user has entered www.test.com and then attempts to enter www.TEST.com. The current behaviour is that after pressing the '+' button or 'go' button the www.TEST.com is removed from the entry box and nothing is added to the list, with no notification to the user.

comment:22 Changed 14 months ago by sven

At the moment there is no notification (or any other hint) for that and the fact that nothing happens (because the item is already in the list) is fine for now. We can improve that by highlighting the already existent entry, of course. But this will happen in an other issue.

comment:23 Changed 14 months ago by mario

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopened due to the following defect:

Environment

iPhone 6
iOS 9.2
ABP 1.1.0

How to reproduce

  1. Open ABP
  2. Open ABP config by tapping the config symbol at the bottom of the app
  3. Open "Whitelisted Websites"
  4. Add one or more whitelisted websites by typing dummy URLs into the input field and tapping "+" (the URL/s will appear in the list below)
  5. Try to remove the added dummy URL/s from the list by tapping the trash bin symbol next to it

Observed behaviour

The trash bin symbol is unresponsive. Sometimes it takes multiple attempts for the app to finally recognize a tap.

Expected behaviour

The trash bin symbols should be more responsive and get a wider hit box range.

comment:24 Changed 14 months ago by fhd

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:25 Changed 14 months ago by scheer

  • Verified working set

Tested on an iPhone 6 Plus with iOS 9.1. and Development build Version 1.0.1 (201601191812).

-The Whitelisting menu option is visible and selectable.

-The user is able to select the input field and the default text (www.website.com) is removed, a cursor is displayed in its place and the keyboard is presented.

-By pressing the ‘+’ or ‘go’ button after entering a website address into the field adds it to the Whitelist, removes ‘no websites yet added’ from the list and the Keyboard is removed.

-The animation shows correctly on adding the first website into the list and every other website thereafter.

-Adding a website more than once (with http://, www., http://www. or in upper/lowercase) does not duplicate the entry in the whitelist and after pressing the ‘+’ or ‘go’ button the duplicate address is removed from the input box, not added to the whiltelist and the input box is set back to its default (www.website.com).

-Adding the same address with a different TLD adds a new entry.

-Selecting the ‘Bin’ icon next to the Whitelisted website removed the selection from the list. Previously there was an issue with the hitbox. Now this is not the case and it is far easier to select the ‘Bin’ icon and remove the Whitelisted website.

-Once a whitelisted website has been entered, ABP is then disabled on that particular web page.

-Removing the whitelisted website thereafter enabled ABP again on that website.

Last edited 14 months ago by scheer (previous) (diff)
Note: See TracTickets for help on using tickets.