Opened 4 years ago

Last modified 4 years ago

#3170 closed defect

Sitekey exception rules do not apply recursively in adblockpluschrome — at Version 4

Reported by: kzar Assignee:
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Platform Keywords: sitekey recursive
Cc: greiner, trev, sebastian Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29328928/

Description (last modified by kzar)

Environment

Adblock Plus for Chrome version 1.9.3 (stable)

How to reproduce

  1. Grab the script from https://gist.github.com/kzar/19c54d2456c0f060e9fc
  2. Run it with Python
  3. Browse to http://localhost:5000
  4. Add the two filters that are listed at the top of the page (ads and the sitekey exception rule)
  5. Refresh the page

Observed behaviour

Only the image outside of the frame is shown.

Expected behaviour

Both the image inside and the image outside of the frame should be shown. (This happens with the Firefox extension.)

Change History (4)

comment:1 Changed 4 years ago by greiner

  • Resolution set to invalid
  • Status changed from new to closed

Due to platform specifics, we look at the HTML "data-adblockkey" attribute only in Firefox and Safari while under Chromium we look at the "X-Adblock-Key" HTTP header. So as mentioned in the documentation both methods need to be implemented for it to work properly.

Therefore please check whether this issue also appears when the header is set and reopen it if that's the case.

comment:2 Changed 4 years ago by kzar

But I'm pretty sure I am returning the X-Adblock-Key header correctly already.

$ curl -I http://localhost:5000
HTTP/1.0 200 OK
Content-Type: text/html; charset=utf-8
Content-Length: 575
X-Adblock-Key: MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANGtTstne7e8MbmDHDiMFkGbcuBgXmiVesGOG3gtYeM1EkrzVhBjGUvKXYE4GLFwqty3v5MuWWbvItUWBTYoVVsCAwEAAQ==_ACqpNMPLn02zyLJMQY98QyJB89DHPQUvWa/hW4aA82A9t3DZzUuCHXGYfF2WNnHqSyQZdjdnimLujyiGkNiAUA==
Server: Werkzeug/0.10.4 Python/2.7.9
Date: Wed, 07 Oct 2015 11:33:11 GMT

comment:3 Changed 4 years ago by greiner

  • Description modified (diff)
  • Resolution invalid deleted
  • Status changed from closed to reopened

Sorry, wasn't checking throughly enough. Indeed, the image inside the frame is not shown but that's not because it was blocked but because it was hidden. Presumably, this was done by element collapsing.

Note that I added the requirement for a blocking filter to the reproduction steps and removed EasyList which allows us to make sure that this behavior is independent of element hiding.

comment:4 Changed 4 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.