Opened 2 years ago

Closed 17 months ago

#3177 closed change (fixed)

Respect the Expires header

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS Keywords: salsita 2015q4
Cc: mario Blocked By: #3176, #3395
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://github.com/adblockplus/adblockplussafariios/pull/29
https://github.com/adblockplus/adblockplussafariios/pull/31

Description (last modified by mario)

Background

#3176 adds meta data to the content blocker lists. One field in there is the Expires field, that defines how long the client should wait until the list is updated. We should respect this value, so we can be more flexible about adjusting the download interval.

What to change

When updating the list, the client should read the Expires header, if present, and schedule the next update check accordingly. If the Expires header is missing, the client should check for updates in five days.

Examples

Please find two example lists attached to this issue.

Attachments (1)

example-block-lists-metadata.zip (1.0 MB) - added by mario 2 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 2 years ago by fhd

  • Summary changed from Support the Expires header to Respect the Expires header

comment:2 Changed 2 years ago by fhd

  • Component changed from Unknown to Adblock-Plus-for-iOS

comment:3 Changed 2 years ago by mario

  • Cc mario added

comment:4 Changed 2 years ago by mario

  • Keywords Salsita added

comment:5 Changed 2 years ago by mario

  • Keywords salsita 2015q4 added; Salsita removed

Changed 2 years ago by mario

comment:6 Changed 2 years ago by mario

  • Description modified (diff)

comment:7 Changed 2 years ago by mario

  • Blocked By 3395 added

comment:8 Changed 21 months ago by jand

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 3177 - Added new cocoa pods dependency

comment:10 Changed 17 months ago by fhd

  • Review URL(s) modified (diff)

comment:11 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 3177 - Respect the Expires header

comment:12 Changed 17 months ago by fhd

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.