Opened 4 years ago

Closed 4 years ago

#3180 closed defect (fixed)

Work around outlook URL rewrites

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fred, oleksandr, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329011

Description

When receiving an Edge verification mail, for example, Outlook 10 seems to rewrite the target URL, violating compliance with RFC 2396:

https://adblockplus.org/verifyEmail?email=example%2540example.com&signature=...&product=edge&lang=en

The above should actually appear as follows:

https://adblockplus.org/verifyEmail?email=example%40example.com&signature=...&product=edge&lang=en

Note the %40 (@) being re-written as %2540 (%40).

Todo

Find a workaround, e.g. an Nginx rewrite, for this case in particular, and encourage our developers to avoid placing plain e-mail addresses in query strings.

Change History (3)

comment:1 Changed 4 years ago by matze

  • Owner set to matze

comment:2 Changed 4 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.