Opened 4 years ago

Closed 2 years ago

#3181 closed change (fixed)

Remove the language part from verification-success URL

Reported by: oleksandr Assignee: ferris
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: matze, saroyanm, oleksandr, fred Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by oleksandr)

Background

We don't have any translations for the verification success page, so it would make sense to make it language agnostic.

What to change

Change the value of successful_verification_redirect_location setting from:

https://adblockplus.org/{lang}/verification-success

to

https://adblockplus.org/verification-success

Change History (9)

comment:1 Changed 4 years ago by matze

How does this fit together with the "rejected" status of #2425? Also, please note that there is no */adblock-browser/verification-success page, it's */verification-success. See #2846 for more information. Cheers!

comment:2 Changed 4 years ago by oleksandr

  • Description modified (diff)

comment:3 Changed 4 years ago by oleksandr

  • Description modified (diff)

comment:4 Changed 4 years ago by oleksandr

This change is just for consistency. Since we don't translate the page anyway it doesn't make sense to have {lang} as a parameter. This is really low priority too.

I have changed the URLs in the description, sorry for the confusion.

comment:5 Changed 4 years ago by matze

  • Cc oleksandr. fred added; oleksandr removed
  • Priority changed from Unknown to P3

comment:6 Changed 4 years ago by matze

  • Cc oleksandr added; oleksandr. removed

comment:7 Changed 4 years ago by saroyanm

Please see #3183, if the ticket is reasonable, then we will not need this changes, because this is a small hack which would be nice to avoid I think.

comment:8 Changed 2 years ago by ferris

  • Owner set to ferris

comment:9 Changed 2 years ago by ferris

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.