Opened 2 years ago

Closed 23 months ago

#3222 closed change (fixed)

Unbreak blockable items list

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: Blocked By: #3258, #3278
Blocking: #1545, #3208, #3226 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329490/
https://codereview.adblockplus.org/29329502/
https://codereview.adblockplus.org/29329622/
https://codereview.adblockplus.org/29329630/
https://codereview.adblockplus.org/29329473/
https://codereview.adblockplus.org/29329479/
https://codereview.adblockplus.org/29329505/
https://codereview.adblockplus.org/29329521/
https://codereview.adblockplus.org/29329654/
https://codereview.adblockplus.org/29329663/
https://codereview.adblockplus.org/29329698/

Description

Background

#3208 will break blockable items list because the data will be attached to nodes in the content process, RequestNotifier won't be able to access it directly any more.

What to change

Split up our current requestNotifier module into requestNotifier and child/requestNotifier. The former should still export the RequestNotifier class but it would message child/requestNotifier in order to perform the scan. Also, the wnd parameter will need to be replaced by the outer window ID.

Change History (23)

comment:1 Changed 2 years ago by trev

  • Blocking 3226 added

comment:2 Changed 2 years ago by trev

  • Blocking 1545 added

comment:3 Changed 2 years ago by trev

  • Blocked By 3208 removed

comment:4 Changed 2 years ago by trev

  • Blocking 3208 added

comment:5 Changed 2 years ago by trev

  • Owner set to trev

comment:6 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:7 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:8 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:9 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:10 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:11 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:12 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:13 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:14 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Pretty much done, will file two follow-up issues.

comment:15 Changed 2 years ago by trev

  • Blocked By 3258 added

comment:16 Changed 2 years ago by trev

  • Blocked By 3259 added

comment:18 Changed 2 years ago by trev

  • Review URL(s) modified (diff)

comment:19 Changed 2 years ago by trev

  • Blocked By 3278 added

comment:20 Changed 2 years ago by mario

  • Keywords 2015q4 added

comment:22 Changed 2 years ago by trev

The remaining changes landed on the e10s branch and will be merged once the blockers are resolved.

comment:23 Changed 23 months ago by trev

  • Blocked By 3259 removed
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.