Opened 5 years ago

Last modified 5 years ago

#3222 closed change

Unbreak blockable items list — at Initial Version

Reported by: trev Assignee:
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: Blocked By: #3208
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329490/
https://codereview.adblockplus.org/29329502/
https://codereview.adblockplus.org/29329622/
https://codereview.adblockplus.org/29329630/
https://codereview.adblockplus.org/29329473/
https://codereview.adblockplus.org/29329479/
https://codereview.adblockplus.org/29329505/
https://codereview.adblockplus.org/29329521/
https://codereview.adblockplus.org/29329654/
https://codereview.adblockplus.org/29329663/
https://codereview.adblockplus.org/29329698/

Description

Background

#3208 will break blockable items list because the data will be attached to nodes in the content process, RequestNotifier won't be able to access it directly any more.

What to change

Split up our current requestNotifier module into requestNotifier and child/requestNotifier. The former should still export the RequestNotifier class but it would message child/requestNotifier in order to perform the scan. Also, the wnd parameter will need to be replaced by the outer window ID.

Change History (0)

Note: See TracTickets for help on using tickets.