Opened 2 years ago

Closed 23 months ago

#3224 closed change (fixed)

Unbreak filter assistant

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: Blocked By:
Blocking: #3208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329884/

Description

Background

#3208 will break the filter assistant because ContentPolicy.refilterNodes() won't work any more. The filter assistant can no longer keep track of the node it is being applied to, they live in different processes.

What to change

Give the filter assistant some kind of node identifier it can work with (worst-case scenario: map node identifiers to nodes in the content processes as long as the filter assistant window is open). Make ContentPolicy.refilterNodes() message the child with that identifier and perform the actual work there.

Change History (6)

comment:1 Changed 2 years ago by trev

  • Blocked By 3208 removed

comment:2 Changed 2 years ago by trev

  • Blocking 3208 added

comment:3 Changed 2 years ago by trev

  • Owner set to trev

comment:4 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by mario

  • Keywords 2015q4 added

comment:6 Changed 23 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.