Opened 4 years ago

Closed 4 years ago

#3225 closed change (fixed)

Unbreak Diagnostics for Adblock Plus

Reported by: trev Assignee: trev
Priority: P2 Milestone: Diagnostics-1.3-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By:
Blocking: #3377 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29331917/
https://codereview.adblockplus.org/29331940/

Description (last modified by trev)

Background

#3208 and other changes broke Diagnostics for Adblock Plus. Part of the issue are numerous API changes, the other part is that Diagnostics currently expects to access our content policy implementation which lives in a different process now.

What to change

Stop tracking low-level calls, only track calls to Policy.shouldAllow(). Adjust to API changes, remove the context info which can no longer be retrieved and "early returns" filter.

Change History (9)

comment:1 Changed 4 years ago by trev

  • Blocked By 3208 removed

comment:2 Changed 4 years ago by trev

  • Blocking 3208 added

comment:3 Changed 4 years ago by trev

  • Blocking 3208 removed

comment:4 Changed 4 years ago by trev

  • Description modified (diff)
  • Owner set to trev
  • Ready set
  • Review URL(s) modified (diff)

comment:5 Changed 4 years ago by trev

  • Review URL(s) modified (diff)

Both changes are under review now - a small one for Adblock Plus and a large one for Diagnostics.

comment:6 Changed 4 years ago by trev

  • Status changed from new to reviewing

comment:7 Changed 4 years ago by trev

  • Blocking 3377 added

comment:9 Changed 4 years ago by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.