Opened on 10/22/2015 at 06:02:02 PM

Closed on 12/07/2015 at 05:25:41 PM

#3225 closed change (fixed)

Unbreak Diagnostics for Adblock Plus

Reported by: trev Assignee: trev
Priority: P2 Milestone: Diagnostics-1.3-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By:
Blocking: #3377 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)


#3208 and other changes broke Diagnostics for Adblock Plus. Part of the issue are numerous API changes, the other part is that Diagnostics currently expects to access our content policy implementation which lives in a different process now.

What to change

Stop tracking low-level calls, only track calls to Policy.shouldAllow(). Adjust to API changes, remove the context info which can no longer be retrieved and "early returns" filter.

Attachments (0)

Change History (9)

comment:1 Changed on 10/23/2015 at 05:48:15 PM by trev

  • Blocked By 3208 removed

comment:2 Changed on 10/23/2015 at 05:48:26 PM by trev

  • Blocking 3208 added

comment:3 Changed on 12/02/2015 at 01:20:36 PM by trev

  • Blocking 3208 removed

comment:4 Changed on 12/04/2015 at 03:00:19 PM by trev

  • Description modified (diff)
  • Owner set to trev
  • Ready set
  • Review URL(s) modified (diff)

comment:5 Changed on 12/04/2015 at 03:39:13 PM by trev

  • Review URL(s) modified (diff)

Both changes are under review now - a small one for Adblock Plus and a large one for Diagnostics.

comment:6 Changed on 12/04/2015 at 03:59:41 PM by trev

  • Status changed from new to reviewing

comment:7 Changed on 12/04/2015 at 04:02:20 PM by trev

  • Blocking 3377 added

comment:8 Changed on 12/07/2015 at 11:26:30 AM by trev

comment:9 Changed on 12/07/2015 at 05:25:41 PM by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.