Changes between Initial Version and Version 4 of Ticket #3225


Ignore:
Timestamp:
12/04/2015 03:00:19 PM (4 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3225

    • Property Blocked By changed from 3208 to
    • Property Ready set
    • Property Owner set to trev
  • Ticket #3225 – Description

    initial v4  
    11=== Background === 
    2 #3208 will break Diagnostics for Adblock Plus because it relies on accessing `PolicyImplementation` - yet that object moves to the content process and becomes inaccessible. 
     2#3208 and other changes broke Diagnostics for Adblock Plus. Part of the issue are numerous API changes, the other part is that Diagnostics currently expects to access our content policy implementation which lives in a different process now. 
    33 
    44=== What to change === 
    5 To be determined. Worst-case scenario - track high-level decisions only, no longer the low-level content policy calls. 
     5Stop tracking low-level calls, only track calls to `Policy.shouldAllow()`. Adjust to API changes, remove the context info which can no longer be retrieved and "early returns" filter. 
  • Ticket #3225 – Review URL(s)

    initial v4  
     1https://codereview.adblockplus.org/29331917/