Opened 2 years ago

Closed 2 years ago

#3227 closed change (fixed)

Unbreak element hiding unit tests

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: e10s 2015q4
Cc: Blocked By:
Blocking: #3108 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329806/

Description

Background

While #3108 fixed element hiding, element hiding unit tests are broken now.

What to change

It seems that the unit tests make wrong timing assumptions, these need to be adjusted.

Change History (4)

comment:1 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by trev

  • Owner set to trev

comment:3 Changed 2 years ago by mario

  • Keywords 2015q4 added

comment:4 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.