Opened 21 months ago

Closed 20 months ago

Last modified 20 months ago

#3228 closed change (fixed)

Unbreak object tabs

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: Blocked By:
Blocking: #3208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329839/

Description (last modified by trev)

Background

#3208 will break object tabs because these will run in the content process now - yet they expect communicating with the prefs and ui modules (figuring out whether they are enabled). Also, they will call into the ui module to open the filter assistant when the tab is clicked.

What to change

Split up objectTabs module into objectTabs and child/objectTabs, the latter having most of the code. The tasks of the objectTabs module would be:

  • Register the user stylesheet
  • Message child/objectTabs whenever it is enabled/disabed
  • Receive messages and call into ui module whenever the object tab has been clicked

Change History (10)

comment:1 Changed 21 months ago by trev

  • Description modified (diff)

comment:2 Changed 21 months ago by trev

  • Blocked By 3208 removed

comment:3 Changed 21 months ago by trev

  • Blocking 3208 added

comment:4 Changed 21 months ago by trev

  • Owner set to trev

comment:5 Changed 21 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 21 months ago by mario

  • Keywords 2015q4 added

comment:7 Changed 20 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 20 months ago by Ross

I don't see object tabs at all for Flash or Java in Firefox 38 or Firefox 45. I have a suspicion this might be my problem though, could someone else double check this?

comment:9 Changed 20 months ago by trev

It works for me in Firefox 42 and 45 as well as SeaMonkey 2.42 on OS X (tested on https://www.adobe.com/software/flash/about/ with Flash installed). What was your configuration?

Last edited 20 months ago by trev (previous) (diff)

comment:10 Changed 20 months ago by trev

I also tested the 2.6.13.4091-beta build on Ollie's laptop (Firefox 42 on Windows), works fine there as well.

Note: See TracTickets for help on using tickets.