Opened 4 years ago

Last modified 4 years ago

#3228 closed change

Unbreak object tabs — at Version 5

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: Blocked By:
Blocking: #3208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329839/

Description (last modified by trev)

Background

#3208 will break object tabs because these will run in the content process now - yet they expect communicating with the prefs and ui modules (figuring out whether they are enabled). Also, they will call into the ui module to open the filter assistant when the tab is clicked.

What to change

Split up objectTabs module into objectTabs and child/objectTabs, the latter having most of the code. The tasks of the objectTabs module would be:

  • Register the user stylesheet
  • Message child/objectTabs whenever it is enabled/disabed
  • Receive messages and call into ui module whenever the object tab has been clicked

Change History (5)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)

comment:2 Changed 4 years ago by trev

  • Blocked By 3208 removed

comment:3 Changed 4 years ago by trev

  • Blocking 3208 added

comment:4 Changed 4 years ago by trev

  • Owner set to trev

comment:5 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.