Opened 4 years ago

Closed 4 years ago

#3238 closed defect (fixed)

Adblock Warning List opt in message should not be triggered by frames (Chrome)

Reported by: arthur Assignee: trev
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329589/

Description (last modified by trev)

Environment

Chrome 46 (Safari and Opera are probably affected as well)
Windows 10 64 bit
Adblock Plus 1.9.3

How to reproduce

  1. Install ABP in a new browser profile
  2. Go to http://www.gutefrage.net/fragen/beliebte/1/30
  3. Disable ABP on that domain
  4. Refresh the page

Observed behaviour

The opt in message for adblock warnings shows up (triggered by the ligatus.com frame).

Expected behaviour

It should not show up, since the top-level document (gutefrage.net) doesn't match anything.

Change History (9)

comment:1 Changed 4 years ago by kzar

  • Priority changed from Unknown to P3
  • Ready set

I could reproduce this issue as described.

comment:2 Changed 4 years ago by arthur

  • Description modified (diff)

comment:3 Changed 4 years ago by Kai

I may add that the notification has no impact on the sites in question even if you click on OK. So the notification is a annoyance to the user and should be removed quickly.

comment:4 Changed 4 years ago by trev

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from P3 to P2

@kzar: An issue without module isn't "ready" by definition ;)

There are actually three separate issues here. One is that Adblock Plus for Chrome checks frames for the anti-adblock notification rather than top-level documents only. The other is that Adblock Plus for Firefox seems to do the same (entirely different code). And finally, there is the issue that showing the anti-adblock notifications when Adblock Plus is disabled makes very little sense.

I'll morph this ticket into reflecting the first issue and create follow-ups on the other issues.

comment:5 Changed 4 years ago by trev

  • Summary changed from Adblock Warning List opt in message should not be triggered when ABP is disabled to Adblock Warning List opt in message should not be triggered by frames (Chrome)

comment:6 Changed 4 years ago by trev

Created follow-ups: #3253, #3254

comment:7 Changed 4 years ago by trev

  • Owner changed from greiner to trev

comment:8 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.