Changes between Version 2 and Version 4 of Ticket #3238


Ignore:
Timestamp:
11/02/2015 11:04:31 AM (4 years ago)
Author:
trev
Comment:

@kzar: An issue without module isn't "ready" by definition ;)

There are actually three separate issues here. One is that Adblock Plus for Chrome checks frames for the anti-adblock notification rather than top-level documents only. The other is that Adblock Plus for Firefox seems to do the same (entirely different code). And finally, there is the issue that showing the anti-adblock notifications when Adblock Plus is disabled makes very little sense.

I'll morph this ticket into reflecting the first issue and create follow-ups on the other issues.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3238

    • Property Priority changed from P3 to P2
    • Property Component changed from Unknown to Platform
  • Ticket #3238 – Description

    v2 v4  
    11=== Environment === 
    2 Chrome 46 or Firefox 41.0.2 (Safari and Opera are probably affected as well) 
     2Chrome 46 (Safari and Opera are probably affected as well) 
    33Windows 10 64 bit 
    4 Adblock Plus 1.9.3 or 2.6.11 
     4Adblock Plus 1.9.3 
    55 
    66=== How to reproduce === 
     
    1111 
    1212=== Observed behaviour === 
    13 The opt in message for adblock warnings shows up. 
     13The opt in message for adblock warnings shows up (triggered by the ligatus.com frame). 
    1414 
    1515=== Expected behaviour === 
    16 It should not show up.  
    17  
    18 In Firefox it also shows up when you disable ABP everywhere.  
    19  
    20 I am assuming it's due to `ligatus.com###warning-bar` being in the list which is triggered by some iframes from ligatus.com. 
     16It should not show up, since the top-level document (gutefrage.net) doesn't match anything.