Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3240 closed change (fixed)

Replace old Adblock Browser icon with new one

Reported by: sven Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.2.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: salsita, mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Shikitita Verified working: yes
Review URL(s):

Description (last modified by fhd)

Background

We're using an old Adblock Browser icon for the app on different places.

What to change

Replace old Adblock Browser icon with new one.

App icon

Settings icon

Spotlight search icon

Hints for testers

These icons are used within iOS, we provide them according to Apple's specifications.

The app icon is used on the home screen, the settings icon is used for the app's section in the iOS settings, the spotlight search icon is displayed in the spotlight search results when searching for the app name.

Change History (33)

comment:1 Changed 4 years ago by sven

  • Cc salsita mario added
  • Description modified (diff)

comment:2 Changed 4 years ago by jand

sven: Size of icon is complete mishmash ( size of icon 180x180 is 181x180, icon 120× 120 is 121 x 120, etc). Icons of size 114x114, 100x100 and 144x144 are missing.

Am I allowed to fix the sizes of the icons and create missing ones?

comment:3 Changed 4 years ago by sven

Seems to be an export issue. Thx for having a look at that. I will quickly fix that.

Changed 4 years ago by sven

Changed 4 years ago by sven

Changed 4 years ago by sven

Changed 4 years ago by sven

Changed 4 years ago by sven

comment:4 Changed 4 years ago by sven

  • Description modified (diff)

comment:5 Changed 4 years ago by sven

Should be ready now.

comment:6 Changed 4 years ago by jand

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 4 years ago by philll

This issue was never set to ready and simply isn't in it's current form. The description does not state where to find any of the changed icons, thus making this completely untestable.

Please describe in great detail, where to find the changed icons.

comment:9 Changed 4 years ago by fhd

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

This is indeed hard to test. Updated the description a little and added hints for testers, so that we can verify that we're setting these icons correctly.

That's all we need to test IMO. How Apple uses those icons is their business, we have no control over it. We provide icons according to their specifications, that's all we can do. Therefore, testing one occurrence should suffice.

comment:10 Changed 4 years ago by fhd

  • Description modified (diff)

comment:11 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

comment:12 Changed 4 years ago by michal.kuric

  • Resolution fixed deleted
  • Status changed from closed to reopened

An old icon is displayed in iOS 8.4.1 spotlight search (build 1.2.0-QA - 600). Tested on iPhone 5C.

Last edited 4 years ago by michal.kuric (previous) (diff)

comment:13 Changed 4 years ago by mario

Batch Modify: Added milestone Adblock-Browser-for-iOS-next for upcoming release.

comment:14 Changed 4 years ago by Shikitita

Would it be possible to know what the exact difference is between the old icon and the new one?

comment:15 Changed 4 years ago by michal.kuric

  • Resolution set to fixed
  • Status changed from reopened to closed

Correct icon shown after nobody did any changes in a code for this purpose.

The old icon was missing a shadow casting on "earth" from the red part of icon.

Last edited 4 years ago by michal.kuric (previous) (diff)

comment:16 Changed 4 years ago by Shikitita

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:17 Changed 4 years ago by mario

  • Resolution set to fixed
  • Status changed from reopened to closed

Remark on why it was reopened and closed again: Shikitita raised concerns regarding a missing icon. However, that wasn't in the scope of this issue and will be handled within a separate issue.

comment:18 Changed 4 years ago by Shikitita

  • Tester changed from Unknown to Shikitita
  • Verified working set
Note: See TracTickets for help on using tickets.