Opened 4 years ago

Closed 2 years ago

#3244 closed defect (rejected)

Pop-up blocker unit tests broken in E10S mode

Reported by: trev Assignee: erikvold
Priority: P4 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By: #3495
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29331996

Description

Environment

Firefox 45.0a1

How to reproduce

  1. Make sure "Enable multi-process Nightly" is enabled in Firefox preferences.
  2. Go into Adblock Plus unit tests preferences, select popupBlocker and click Run.

Observed behaviour

The test opens pop-up windows but doesn't close them. Closing them manually makes the test complete, albeit with failures.

Expected behaviour

The test should run through without issues, as it does when E10S is disabled.

Change History (8)

comment:1 Changed 4 years ago by erikvold

  • Owner set to erikvold

comment:2 Changed 4 years ago by erikvold

  • Review URL(s) modified (diff)

comment:4 Changed 4 years ago by erikvold

Just for the record, these where the errors that I saw in the console before my patch is applied:

unsafe CPOW usage remote-browser.xml:164:0
unsafe CPOW usage popupBlocker.js:119:4
TypeError: browser.contentWindow.addEventListener is not a function popupBlocker.js:93:1
GET
http://127.0.0.1:1234/redirect [HTTP/1.1 302 Moved Temporarily 4ms]
GET
http://127.0.0.1:1234/test [HTTP/1.1 200 OK 7ms]
unsafe CPOW usage remote-browser.xml:164:0
unsafe CPOW usage popupBlocker.js:119:4
TypeError: browser.contentWindow.addEventListener is not a function

comment:5 Changed 4 years ago by erikvold

  • Blocked By 3495 added

comment:6 Changed 4 years ago by erikvold

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 4 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

It seems that there are two issues with the solution here, too bad I didn't test it earlier:

  1. The tests won't work with the pop-up blocker enabled (previously we were simulating proper user clicks that the built-in pop-up blocker wouldn't catch).
  2. It seems that tabs.on("ready") functionality in the Add-on SDK relies on E10S compatibility shims. Since Adblock Plus no longer uses them the test won't work in E10S mode.

comment:8 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from reopened to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.