Save data from element hiding hits again
With the changes from #3208 the elemHide module will call Policy.shouldAllow() in order to check whether a hiding filter should be active. However, only the allow key of the response is considered, the hits key is ignored and the data isn't stored.
What to change
Have the child/elemHide module call shouldAllow from the child/contentPolicy module instead of using its own message to communicate with the parent. The key should be sent as location parameter and resolving it into a filter should happen in Policy.shouldAllow().
Ideally, we should add a parameter callback to Policy.shouldAllow() in order to allow it being called in an asynchronous way (with async message passing). This will require a proper abstraction for responses, similar to the way it was implemented in ext/common.
Change History (5)
comment:2 Changed 17 months ago by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing