Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3253 closed change (fixed)

Adblock Warning List opt in message should not be triggered by frames (Firefox)

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329597/

Description

Background

Adblock Plus for Firefox has an issue similar to #3238 - anti-adblock warning can be triggered by frames. However, the test case from #3238 doesn't work for me because the logic determining document URL is flawed (subject.location.href cannot be expected to be set in content-document-global-created observer notification).

What to change

Fix document URL retrieval in ui module's content-document-global-created handler. Make sure that it only applies to top frames.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Owner set to trev

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)

comment:3 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by trev

  • Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox

Adblock Plus 2.6.12 is being released from branch, this change is part of it.

Note: See TracTickets for help on using tickets.