Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3254 closed change (fixed)

Anti-adblock warning should not show when Adblock Plus is disabled

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329604/
https://codereview.adblockplus.org/29329776/

Description

Background

Anti-adblock notification will currently show up even if Adblock Plus is disabled, this makes no sense.

What to change

Make antiadblockInit check Prefs.enabled and verify that the site isn't whitelisted.

Change History (8)

comment:1 Changed 3 years ago by trev

  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Owner set to trev

comment:3 Changed 3 years ago by trev

  • Review URL(s) modified (diff)

comment:4 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening: the patch fails to consider that nsIURI.host can throw.

comment:6 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:7 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by trev

  • Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox

Adblock Plus 2.6.12 is being released from branch, this change is part of it.

Note: See TracTickets for help on using tickets.