Opened 4 years ago

Closed 4 years ago

#3255 closed change (fixed)

Update adblockplus repository dependency to revision c4ffcee891c3

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329625/

Description

Background

Updating dependency is necessary in order to get #3254 fixed on Chrome. In addition, the changes from #2580, #3108 and #3253 will be imported. Out of these, only #3108 touches files which is imported into the Chrome build - this particular code path isn't being executed however (other than AboutHandler no longer being imported in the elemHide module).

What to change

No changes are necessary beyond updating dependency. However, removing the fake elemHideHitRegistration module is a good idea, it is no longer required.

Hints for testers

With these changes, the anti-adblock notification should no longer show up on websites like spele.nl if Adblock Plus isn't disabled there. Also, element hiding functionality should be tested again (not related to any specific websites).

Change History (2)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.