Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3259 closed change (fixed)

Store blockable item selection in the content process

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By: #3491
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333172/

Description

Background

With #3222 fixed the blockable items will still call RequestNotifier.storeSelection() and RequestNotifier.getSelection() on the DOM window - meaning that it still works via cross-process wrappers and might potentially lose information (WeakMap doesn't see to support these wrappers properly).

What to change

Make RequestNotifier.storeSelection() and RequestNotifier.getSelection() take outerWindowID as parameter and store the data in the child. Blockable items implementation will have to adjust slightly for RequestNotifier.getSelection() being async.

Change History (6)

comment:1 Changed 4 years ago by trev

  • Blocking 3222 removed

comment:2 Changed 4 years ago by trev

  • Owner set to trev

comment:3 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by trev

  • Blocked By 3491 added

comment:6 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Blockable items list appears to be working correctly.

ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.