Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3269 closed change (fixed)

Have the uninstallation page open in a new tab when Adblock Plus for Chrome/Opera/Safari is uninstalled

Reported by: saroyanm Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: greiner, kzar, snoack, fhd Blocked By: #3257, #3271, #3403
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332492/

Description (last modified by kzar)

Background

In order to better understand why users uninstall Adblock Plus we are creating an uninstallation page (see #3257). The page will be displayed to the user when they uninstall the extension, and it will ask the user why they have chosen to uninstall.

We now need to modify adblockpluschrome so the uninstallation page is actually displayed.

What to change

After uninstallation of Adblock Plus for Chrome/Opera/Safari open the uninstallation page https://adblockplus.org/{locale}/uninstall-abp in a new tab, passing in the following query parameters:

  • addonName (info module)
  • addonVersion (info module)
  • application (info module)
  • applicationVersion (info module)
  • platform (info module)
  • platformVersion (info module)
  • lang (appLocale in Utils module)
  • notificationDownloadCount (Prefs module)

The extension should use the redirection as specified in #3403, so for example:

https://adblockplus.org/redirect?link=uninstall-abp&lang=en-GB&addonName=adblockpluschrome&addonVersion=1.9.4&application=chrome&applicationVersion=47.0.2526.73&platform=chromium&platformVersion=47.0.2526.73&notificationDownloadCount=0

which will redirect to:

https://adblockplus.org/en/uninstall-abp?lang=en-GB&addonName=adblockpluschrome&addonVersion=1.9.4&application=chrome&applicationVersion=47.0.2526.73&platform=chromium&platformVersion=47.0.2526.73&notificationDownloadCount=0

Change History (15)

comment:1 Changed 4 years ago by saroyanm

  • Summary changed from Open uninstallation page in new tab to Open uninstallation page in new tab for chrome after ABP uninstall

comment:2 Changed 4 years ago by greiner

  • Cc greiner added
  • Description modified (diff)

notificationDownloadCount maxes out at 4+ so I adapted the ticket description accordingly.

comment:3 Changed 4 years ago by kzar

  • Cc kzar trev fhd added
  • Description modified (diff)
  • Summary changed from Open uninstallation page in new tab for chrome after ABP uninstall to Have the uninstallation page open in a new tab when Adblock Plus for Chrome/Opera/Safari is uninstalled

I've tidied up the description and title a little bit. Before I mark this ready though I want to check, is sending all that user information in the query parameters in line with our privacy policy? (Is it something that has been considered?)

comment:4 Changed 4 years ago by greiner

This has already been discussed in the project proposal. For discussions about the privacy policy I'd suggest involving yourself in #3271.

comment:5 Changed 4 years ago by trev

  • Cc snoack added; trev removed

It's generally a good idea to add the module owner to the Cc list and not some random guy ;)

comment:6 Changed 4 years ago by kzar

You're hardly "some random guy" Wladimir, the reason I CCd you and Felix was that you're both proponents of user privacy and I wanted to make sure you were both aware of what was planned in this ticket. (Besides, Sebastian is away at the moment and I'm the stand-in module owner in the mean time and I did CC myself :p .)

comment:7 Changed 4 years ago by kzar

  • Priority changed from Unknown to P2
  • Ready set

As there have apparently been no objections to the data collection and Kai has approved the privacy policy changes too I'll set this to ready.

comment:8 Changed 4 years ago by saroyanm

  • Blocked By 3271 added

comment:9 Changed 4 years ago by kzar

  • Owner set to kzar

comment:10 Changed 4 years ago by fhd

Just to confirm, yes, the data above is exactly what I remember we discussed.

comment:11 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

FYI - Opening the uninstallation page seems possible only for Opera and Chrome, apparently Safari doesn't provide a method to do it.

comment:12 Changed 4 years ago by kzar

  • Blocked By 3403 added

comment:13 Changed 4 years ago by kzar

  • Description modified (diff)

comment:14 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 4 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.