Opened 4 years ago

Closed 4 years ago

#3274 closed change (fixed)

Unbreak toolbar icon tooltip

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By: #3278
Blocking: #3208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329810/
https://codereview.adblockplus.org/29329815/

Description

Background

With #3208 fixed the toolbar icon tooltip no longer works - window stats are stored in the content process and cannot be retrieved.

What to change

Update RequestNotifier.getWindowStatistics() to take an outerWindowID as parameter and forward the call to the child. Make ui module fill the tooltip asynchronously, as the data is received.

Change History (5)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Blocked By 3278 added

comment:3 Changed 4 years ago by trev

  • Owner set to trev

comment:4 Changed 4 years ago by trev

First part of this landed on e10s branch: https://hg.adblockplus.org/adblockplus/rev/85b5a0ec0fb0

comment:5 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

The other part landed on e10s branch as well:

https://hg.adblockplus.org/adblockplus/rev/1d4c58ebd249

Note: See TracTickets for help on using tickets.