Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3297 closed defect (fixed)

Fix issues introduced by recent libadblockplus changes and update dependencies

Reported by: rjeschke Assignee: rjeschke
Priority: P2 Milestone:
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By: #3294, #3296
Blocking: #3299 Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329928/

Description (last modified by rjeschke)

Fix issues introduced by #1284, #2693 and #768, this means:

  1. Refactor Notification handling from polling in a thread to callback-based, this results in an API change for FilterEngine.java
  2. Remove tr1 references from JNI code
  3. Remove id from AppInfo.java (according to #1284)
  4. Update Android.mk and Application.mk to reflect changes from #768
  5. Increase minSDK version in AndroidManifest.xml and Application.mk from 7 to 9
  6. Change libadblockplus-binaries dependency for mercurial to ead443e75f08 and for git to f403049

Change History (11)

comment:1 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:2 Changed 4 years ago by rjeschke

  • Description modified (diff)
  • Summary changed from Fix issues introduced by recent libadblockplus changes to Fix issues introduced by recent libadblockplus changes and update dependencies

comment:3 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:4 Changed 4 years ago by rjeschke

  • Owner set to rjeschke

comment:5 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:6 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:7 Changed 4 years ago by rjeschke

  • Blocking 3299 added

comment:8 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 4 years ago by rjeschke

  • Blocked By 3294, 3296 added

comment:10 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 4 years ago by rjeschke

  • Description modified (diff)
Note: See TracTickets for help on using tickets.