Opened 4 years ago

Closed 4 years ago

#3307 closed change (fixed)

Create class adblockplus::log::rotation

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fred, fhd Blocked By: #3306, #3479
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333281/

Description (last modified by matze)

As counter-part for issue #3306, we want to extend many of our log-rotation setups to include a final step that uploads the rotated file to the newly introduced, central log-server.

What to do

In order to avoid hard-coding the entire configuration for every log file, the idea is to introduce a template that can handle the most common cases with just a few parameters.

Notes

Since we do not want to introduce too much overhead (especially in testing and deploy) right now, this should be done in a new class named adblockplus::log::rotation, wrapping the existing logrotate module. This is aligned with the other new entities introduced in this context (i.e. adblockplus::log::master and adblockplus::log::uplink), as well as the long-term goal to refactor logrotate into adblockplus::log::* anyway.

Change History (4)

comment:1 Changed 4 years ago by matze

  • Blocked By 3479 added

comment:2 Changed 4 years ago by matze

  • Blocked By 3306 added
  • Cc fred fhd added
  • Description modified (diff)
  • Ready set
  • Review URL(s) modified (diff)
  • Sensitive unset
  • Status changed from new to reviewing
  • Summary changed from Migrate log rotation setup to Create class adblockplus::log::rotation

comment:4 Changed 4 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.