Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#331 closed change (fixed)

Remove localStorage to FileSystem migration code

Reported by: trev Assignee: saroyanm
Priority: P3 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Opera
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5719985141841920/

Description (last modified by saroyanm)

Background

We were originally using localStorage to store our data in Opera and switched over to FileSystem API later. This was several releases ago but there is still migration code running every time the extension initializes and looking for patterns.ini in localStorage.

What to change

Remove the migration code and the complexity that it introduces.

Hint for testers

This issue can affect only users who had stored data in localStorage with key patterns.ini, while the migration code was introduced long time ago (9 month) and were migrating the data with each new version of ABP, It can only affect users if they didn't get update for more than half a year.

Change History (8)

comment:1 Changed 5 years ago by saroyanm

  • Owner set to saroyanm
  • Platform set to Unknown

comment:2 Changed 5 years ago by saroyanm

  • Platform changed from Unknown to Opera

comment:3 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by saroyanm

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

comment:6 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:7 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:8 Changed 5 years ago by saroyanm

  • Description modified (diff)
Note: See TracTickets for help on using tickets.