Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3326 closed change (fixed)

Update adblockplusui repository dependency to revision f05c5331d8b9

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29330720/

Description (last modified by trev)

Background

We should update adblockplusui repository dependency before Adblock Plus for Firefox release, mostly because of #2018. There are more changes but this are irrelevant for the Firefox release: #2381, #2410.

What to change

Updating the dependency should be sufficient

What to test

First-run page should still work after this change.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-2.6.12-for-Firefox
  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 4 years ago by trev

  • Description modified (diff)
  • Summary changed from Update adblockplusui repository dependency to revision 37ce1542cfa5 to Update adblockplusui repository dependency to revision f05c5331d8b9

Changed dependency update to an older revision, #2396 changes depend on code that hasn't landed yet:

https://hg.adblockplus.org/adblockplus/rev/80c79416ce64
https://hg.adblockplus.org/adblockplus/rev/47812d8795d7

comment:3 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.