Opened 2 years ago

Closed 2 years ago

#3331 closed change (fixed)

Update buildtools repository dependency to revision a61155d8764a

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29330280/

Description (last modified by kzar)

Background

We should update the buildtools dependency before releasing Adblock Plus for Chrome/Opera/Safari 1.9.4. The following changes will be included:

Noissue - Avoid "detached head" when using Git branches
Issue 3260 - Remove expression closure from build tools
Issue 2972 - Properly generate Git ignore paths for dependencies
Issue 3194 - Support multiple VCS specific URLs with new syntax

What to change

Updating the dependency and include the updated ensure_dependencies.py script.

What to test

  • That the build still works with the included ensure_dependencies.py updates. (Check that the dependencies are fetched correctly, the correct revisions checked out.)

(There was also a change to bootstrap.js included here, but that appears to be only used by packagerGecko.py and therefore should not matter.)

Change History (2)

comment:1 Changed 2 years ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.