Opened 2 years ago

Closed 2 years ago

#3335 closed change (fixed)

Update adblockplusui repository dependency to revision f05c5331d8b9

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-for-1.9.4-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29330326/

Description (last modified by kzar)

Background

We should update the adblockplusui dependency before releasing Adblock Plus for Chrome/Opera/Safari 1.9.4. The following changes will be included:

Issue 2381 - Added share overlay to options page
Issue 2410 - Improved accessibility of dialogs in options page
Issue 2018 - Optimized first-run page for smaller screens

What to change

Update the dependency and add the new adblockplusui/skin/common.{js,css} files to the file mapping section in metadata.common.

What to test

  • The first run page.
  • The options page.

Change History (3)

comment:1 Changed 2 years ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 in reply to: ↑ description Changed 2 years ago by sebastian

  • Cc sebastian added

Replying to kzar:

Issue 3031 - Translations for Adblock Browser section in First Run Page

This change has already been included with the previous dependency update.

Also You might want to consider using TicketQuery.

comment:3 Changed 2 years ago by kzar

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.