Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3343 closed change (fixed)

Do not unescape URLs

Reported by: oleksandr Assignee: eric@…
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, sergz, eric@… Blocked By:
Blocking: #3300 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29330709/

Description (last modified by oleksandr)

Background

We are currently unescaping the URLs before the ShouldBlock call in the traverser. This causes issues like: #3300. Bases on discussion in #3311 we shouldn't unescape before the Matches call at all. Seeing that we don't generally need to unescape URLs anywhere at all, we can just remove the UrlUnescape everywhere.

What to change

Remove UrlUnescape definition and calls.

Change History (3)

comment:1 Changed 4 years ago by oleksandr

  • Description modified (diff)
  • Owner set to eric@…
  • Review URL(s) modified (diff)
  • Summary changed from Do not unescape URLs before the ShouldBlock call to Do not unescape URLs

comment:2 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.