Changes between Initial Version and Version 1 of Ticket #3343


Ignore:
Timestamp:
11/25/2015 02:19:15 AM (4 years ago)
Author:
oleksandr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3343

    • Property Owner set to eric@…
    • Property Summary changed from Do not unescape URLs before the ShouldBlock call to Do not unescape URLs
  • Ticket #3343 – Description

    initial v1  
    11=== Background === 
    2 We are currently unescaping the URLs before the ShouldBlock call in the traverser. This causes issues like: #3300. Bases on discussion in #3311 we shouldn't unescape before the Matches call at all. 
     2We are currently unescaping the URLs before the ShouldBlock call in the traverser. This causes issues like: #3300. Bases on discussion in #3311 we shouldn't unescape before the Matches call at all. Seeing that we don't generally need to unescape URLs anywhere at all, we can just remove the UrlUnescape everywhere. 
    33 
    44=== What to change === 
    5 Remove the unescaping before the ShouldBlock call in the traverser. 
     5Remove UrlUnescape definition and calls. 
  • Ticket #3343 – Review URL(s)

    initial v1  
     1https://codereview.adblockplus.org/29330709/