Opened 4 years ago

Closed 4 years ago

#3376 closed defect (rejected)

'Blockable items' panel uses inappropriate colors when using the dark developer edition theme

Reported by: darkblue Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Windows 10 x64, Nightly 45.0a1 x64, ABP 2.6.13.4088 -beta with EasyList.

How to reproduce

  1. Open any site.
  2. Open about:addons|Appearance and change the theme from 'Default' to the 'Developer edition' theme
  3. Open Developer tools(F12)|'Toolbox Options' and change the theme from 'Light' to 'Dark'
  4. Open blockable items (Ctrl+Shift+V)

Observed behaviour

The 'blockable items' panel uses inverted colors for its title, and normal colors (as in the 'Light Theme' in developer tools) for its content.
Screenshot: https://i.imgur.com/ZihGcUx.jpg

Expected behaviour

The panel should use the Dark(Developer edition) theme in both its title and content

Change History (2)

comment:1 Changed 4 years ago by greiner

  • Cc greiner added
  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Summary changed from The 'blockable items' panel uses inverted colors for it's title and white background for it's content when using the 'Developer edition' theme together with 'Dark' theme in Developer tools to 'Blockable items' panel uses inappropriate colors when using the dark developer edition theme

comment:2 Changed 4 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Problem is, "Developer Edition" isn't an actual theme. It's a single file under chrome://browser/skin/devedition.css which is loaded from browser.xul and modifies the browser UI slightly - a publicity stunt mostly. It's not meant to apply to extension content, and there is no real way to make it apply there. The only way would be duplicating the color scheme in our own CSS file and apply it if we detect the "Developer Edition" theme - a very error-prone approach which is bound to cause issues when new Firefox releases come out. So I don't really see a viable way.

Note: See TracTickets for help on using tickets.