Opened 4 years ago

Closed 2 years ago

#3379 closed defect (rejected)

filterListener unit tests are broken

Reported by: erikvold Assignee: erikvold
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29332054

Description (last modified by trev)

Environment

OSX, Firefox Nighty 45.0a1 (2015-12-04)

How to reproduce

Run filterListener unit tests

Observed behaviour

The following tests fail:

Filter listener: Adding and removing filters (7, 12, 19)
Filter listener: Filter subscription operations (3, 41, 44)

Expected behaviour

passing tests.

Background

This is fallout from ​bug 673569, the unit tests are accessing private module variables which are no longer global.

What to change

Make the affected variables properly global (change let to var).

Change History (5)

comment:1 Changed 4 years ago by trev

  • Cc trev added
  • Description modified (diff)

The question is how we want to address this. Simplest solution would be replacing let by var for the relevant variables. Question is, is there a better solution?

comment:2 Changed 4 years ago by trev

  • Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Firefox
  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 4 years ago by erikvold

  • Owner set to erikvold

comment:4 Changed 4 years ago by erikvold

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.