Opened 4 years ago

Closed 2 years ago

#3381 closed defect (rejected)

notification unit tests are broken

Reported by: erikvold Assignee: erikvold
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332044

Description (last modified by trev)

Environment

OSX, Firefox Nighty 45.0a1 (2015-12-04)

How to reproduce

Run notification unit tests

Observed behaviour

All of the tests in this suite appear to fail due to the beforeEach function:

beforeEach failed on No data: NotificationModule.downloader is undefined@ 1 ms
Source: 	

.setup/<@chrome://adblockplustests/content/tests/notification.js:33:9
setupVirtualTime@chrome://adblockplustests/content/common.js:157:5
.setup@chrome://adblockplustests/content/tests/notification.js:30:1

No notifications should be returned if there is no data@ 2 ms
afterEach failed on No data: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]@ 2 ms
Source: 	

ObserverInterposition.methods.removeObserver@resource://gre/modules/RemoteAddonsParent.jsm:388:5
AddonInterpositionService.prototype.interposeProperty/desc.value@resource://gre/components/multiprocessShims.js:160:52
restoreVirtualTime@chrome://adblockplustests/content/common.js:280:3
.teardown@chrome://adblockplustests/content/tests/notification.js:66:7

Expected behaviour

passing tests.

Background

This is fallout from bug 673569, the unit tests are accessing private module variables which are no longer global.

What to change

Make the affected variables properly global (change let to var).

Change History (7)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)

comment:2 Changed 4 years ago by trev

  • Cc trev added

comment:3 Changed 4 years ago by trev

  • Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Ready set

comment:4 Changed 4 years ago by erikvold

  • Owner set to erikvold

comment:5 Changed 4 years ago by erikvold

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by wspee

This ticket should be "fixed", see 0658b65ae7a2?

comment:7 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.