Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3383 closed change (fixed)

Clean up browser-site handling in CPluginClass

Reported by: eric@… Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: #3382 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29323561/

Description

Background

CPluginClass has a number of deficiencies involving its site pointer.

What to change

  • Make initialization parallel: assign site pointer at the beginning, assign nullptr at the end.
  • Remove unnecessary synchronization around the site pointer.
  • Eliminate use of FinalConstruct and FinalRelease. This pair were not needed.

Change History (4)

comment:1 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)

comment:2 Changed 4 years ago by oleksandr

  • Cc oleksandr added
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.