Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3395 closed change (fixed)

Support new filter list structure containing meta data

Reported by: mario Assignee: jand
Priority: P2 Milestone: Adblock-Plus-for-iOS-1.1.0
Module: Adblock-Plus-for-iOS/macOS Keywords: salsita
Cc: Blocked By:
Blocking: #3177 Platform: iOS
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockplussafariios/pull/16

Description (last modified by mario)

Background

#3176 introduces meta data to all of our filter lists. This meta data will be served for iOS filter lists as well. Please consult #3176 for the new data structure. In order to be able to still perform automatic filter list updates (introduced by #3093) the new data structure needs to be supported.

Please note, that this issue only introduces the capability to load and process the new data structure on top of the old data structure. The handling of meta data is covered by #3177.

Example files with the new data structure.

What to change

On top of the currently used filter list data structure provide support for the new filter list data structure introduced by #3176.

Remark for testers

This functionality can be tested by tapping "Update Filter List" in the app's settings. Please note, that - in order to fully test this change - a new list with the new data structure needs to be provided to the app by our backend.

Attachments (1)

example-block-lists-metadata.zip (1.0 MB) - added by mario 4 years ago.

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by mario

comment:1 Changed 4 years ago by mario

  • Description modified (diff)

comment:2 Changed 4 years ago by mario

  • Blocking 3177 added

comment:3 Changed 4 years ago by jand

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Mario: Testing of filter list processing is partially covered by unit tests.

comment:4 Changed 4 years ago by fhd

  • Resolution fixed deleted
  • Status changed from closed to reopened

Please don't close issues that haven't landed yet.

comment:5 Changed 4 years ago by fhd

  • Owner set to jand

comment:6 Changed 4 years ago by fhd

  • Milestone set to Adblock-Plus-for-iOS-1.1.0
  • Ready set
  • Status changed from reopened to reviewing

comment:7 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Tested updating lists before and after asking Felix to update it to the new format on the server and everything appears to be working correctly.

ABP for iOS 1.0.1 (201601191812)
iPhone 5S / iOS 9.2

Note: See TracTickets for help on using tickets.