Opened 4 years ago

Last modified 4 years ago

#3402 closed defect

[CMS] Allow links inside of inline tags for translatable strings — at Version 1

Reported by: saroyanm Assignee: kzar
Priority: P3 Milestone:
Module: Sitescripts Keywords: cms
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332956/

Description (last modified by kzar)

Background

Our CMS allows some inline HTML tags (a, em, sup, strong, code, span) inside of translatable strings. These tags can even be nested.

It appears that this does not work correctly when an <a> tag (Or perhaps any tag with an attribute?) is nested inside of another inline tag. In that case the containing tag ends up being HTML escaped.

What to change

Ensure that links inside of inline tags do not cause the the inline tag to be escaped. With example Hello world <sup><a href="#ref">1</a></sup>, the opening and closing sup tags should not be escaped.

Change History (1)

comment:1 Changed 4 years ago by kzar

  • Description modified (diff)
  • Keywords cms added
  • Owner set to kzar
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Allow nested inline tags in translation string to [CMS] Allow links inside of inline tags for translatable strings

Note: Nested inline tags work generally, as a work around you could do something like this: <a href="#ref"><sup>1</sup></a>

Note: See TracTickets for help on using tickets.