Opened 4 years ago

Closed 4 years ago

#3404 closed change (fixed)

Add platform directory to devenv path

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334723/
https://codereview.adblockplus.org/29334706/

Description (last modified by kzar)

Background

Currently when development builds of the extension are generated they are placed in the devenv/ directory for all platforms. This can make testing a change on multiple platforms slightly painful.

What to change

Change the development build directory do be devenv.platform for example devenv.chrome, devenv.safari or devenv.opera.

We will also need to update .gitignore and .hgignore files for adblockpluschrome and update the buildtools dependency.

The buildtools dependency will need be changed from a0d797251f12 to fd9026e57498. There have been a few other commits since, mostly relating to licence headers. One other commit since removes some code to do with generating icons at build time which is no longer required.

Change History (8)

comment:1 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 4 years ago by kzar

  • Description modified (diff)

comment:4 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)

comment:5 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)

comment:6 Changed 4 years ago by kzar

  • Description modified (diff)
Version 0, edited 4 years ago by kzar (next)

comment:7 Changed 4 years ago by kzar

  • Description modified (diff)

comment:8 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.