Opened on 12/10/2015 at 07:58:21 PM
Closed on 01/27/2016 at 04:40:45 PM
#3404 closed change (fixed)
Add platform directory to devenv path
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29334723/ |
||
Description (last modified by kzar)
Background
Currently when development builds of the extension are generated they are placed in the devenv/ directory for all platforms. This can make testing a change on multiple platforms slightly painful.
What to change
Change the development build directory do be devenv.platform for example devenv.chrome, devenv.safari or devenv.opera.
We will also need to update .gitignore and .hgignore files for adblockpluschrome and update the buildtools dependency.
The buildtools dependency will need be changed from a0d797251f12 to fd9026e57498. There have been a few other commits since, mostly relating to licence headers. One other commit since removes some code to do with generating icons at build time which is no longer required.
Attachments (0)
Change History (8)
comment:1 Changed on 12/10/2015 at 08:07:15 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/25/2016 at 02:26:20 PM by sebastian
- Priority changed from Unknown to P4
- Ready set
comment:6 Changed on 01/27/2016 at 02:33:39 PM by kzar
- Description modified (diff)
comment:8 Changed on 01/27/2016 at 04:40:45 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/buildtools/rev/fd9026e57498