Opened 5 years ago

Last modified 5 years ago

#3409 new change

Make sure ABP for IE extracts the URL of the HTML OBJECT tag correctly

Reported by: oleksandr Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



We are extracting the URL of the HTML OBJECT tag in AdblockPlusDomTraverser.cpp. We are currently assuming IE will always give us an uppercase string on input, but it looks like most recent IE version does not do HTML normalization.
The relevant code is int posBegin = sObjectHtml.Find(L"VALUE=\"");

What to change

Fix the URL extraction to support both lower and upper case characters.

Change History (1)

comment:1 Changed 5 years ago by oleksandr

  • Cc oleksandr added; AdelaideODoherty removed
Note: See TracTickets for help on using tickets.