Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#341 closed defect (fixed)

Pop-up blocking fails if the pop-up URL redirects

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: arthur Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



Firefox 31.0a1 nightly, Adblock Plus, Adblock Plus unit tests 1.0.1a.320.

How to reproduce

  1. Open chrome://adblockplustests/content/index.html?test=popupBlocker

Observed behaviour

Multiple tests fail, only the immediate pop-up URL can be blocked but not the URL it redirects to. Also, some tests expect to see but it appears to have been resolved in current Firefox versions.

Expected behaviour

No test failures.

Change History (7)

comment:1 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:4 Changed 6 years ago by arthur

If you block the URL the popup redirects to and not the immediate pop-up URL, ABP isn't acually closing the popup/new tab anymore.

E.g. add this filter


and got to your testcase Once you click on "Click here" the new tab should be blocked/closed but isn't.

Let me know if you want a separate bug report for that.

comment:5 Changed 6 years ago by arthur

  • Cc arthur added

comment:6 Changed 6 years ago by trev

Yes, please create a separate issue for that.

comment:7 Changed 6 years ago by arthur

Ok, done: #443.

Note: See TracTickets for help on using tickets.