Opened 4 years ago

Closed 4 years ago

#3410 closed change (fixed)

Make press page in eyeo.com more easy manageable by non developers

Reported by: saroyanm Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334171/

Description (last modified by greiner)

Background

With #3366 we are implementing press page in eyeo.com, but because of tight schedule it's not yet been implemented in the way that it will allow to update press documents on page by non developers.

What to change

Implement a function that will sort reasons according to date field in YYYY-MM-DD and output in MM DD, YYYY format where MM is the name of the month in English (eg: September, November and etc.).

Change History (6)

comment:1 follow-up: Changed 4 years ago by greiner

  • Cc greiner added
  • Description modified (diff)

I corrected the date format to reflect what was agreed on in #3366.

Generally, it would be great if we could support other languages as well. Therefore it would be nice if we could

  1. translate the dates
  2. specify the date format per language and fall back to a default one (e.g. YYYY-MM-DD) if none is specified

Feel free to choose whether to reject, include it in this ticket or create a separate ticket for that.

comment:2 in reply to: ↑ 1 Changed 4 years ago by saroyanm

Replying to greiner:

I corrected the date format to reflect what was agreed on in #3366.

Generally, it would be great if we could support other languages as well. Therefore it would be nice if we could

  1. translate the dates
  2. specify the date format per language and fall back to a default one (e.g. YYYY-MM-DD) if none is specified

Feel free to choose whether to reject, include it in this ticket or create a separate ticket for that.

I'd rather leave it after translating Eyeo.com, because currently it's available only in English and not sure if it does make sense to have translation right now.

comment:3 Changed 4 years ago by juliandoucette

  • Owner set to juliandoucette

comment:4 Changed 4 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • I renamed the old datesort filter and updated the team template to avoid confusion
  • I wrote a new datesort that sorts and mutates the date inside the collection argument based on an inputFormat and outputFormat
  • I updated the press page to use the new datesort

I wasn't sure about the filter names here. I'm open to suggestion.

comment:5 Changed 4 years ago by saroyanm

Just as a reminder, I think it's also make sense to implement check for ASCII characters in PDF names if possible, because whenever NON ASCII character is presented in PDF name we were having problem in the static files generation:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 55: ordinal not in range(128)

comment:6 Changed 4 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.