Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3415 closed change (fixed)

Detect application based on UA for Chromium-based browsers

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332680

Description (last modified by sebastian)

Background

Currently, info.application is hard-coded to "chrome" and "opera" in the respective builds. However, when we use a unified build for all Chromium-based browsers (currently under discussion) that won't work anymore. But even until then this information is redundant with addonName which is "adblockpluschrome" and "adblockplusopera" respectively, at the moment. Moreover, currently, other Chromium-based browser (e.g. Yandex.Browser) are mistakenly reported as Chrome.

What to change

  • Detect info.application on the client-side, based on the user agent string.
  • Also make sure that info.applicationVersion refers to that application.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 4 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.