Changes between Version 1 and Version 3 of Ticket #3415


Ignore:
Timestamp:
12/16/2015 12:44:59 PM (4 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3415

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed

  • Ticket #3415 – Description

    v1 v3  
    11=== Background === 
    2 Currently, `info.application` is hard-coded to `"chrome"` and `"opera"` in the respective builds. However, if we should ever drop the Opera-specific builds in the future that won't work anymore. And even until then this information is redundant with `addonName` which is `"adblockpluschrome"` and `"adblockplusopera"` respectively, at the moment. Moreover, other Chromium-based browser (e.g. Yandex.Browser) are mistakenly reported as Chrome.  
     2Currently, `info.application` is hard-coded to `"chrome"` and `"opera"` in the respective builds. However, when we use a unified build for all Chromium-based browsers (currently under discussion) that won't work anymore. But even until then this information is redundant with `addonName` which is `"adblockpluschrome"` and `"adblockplusopera"` respectively, at the moment. Moreover, currently, other Chromium-based browser (e.g. Yandex.Browser) are mistakenly reported as Chrome.  
    33 
    44=== What to change === 
    5 Determine `info.application` at runtime, based on the user agent string. 
     5Detect `info.application` on the client-side, based on the user agent string.