Opened 4 years ago

Last modified 4 years ago

#3415 closed change

Detect application based on UA for Chromium-based browsers — at Version 1

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332680

Description

Background

Currently, info.application is hard-coded to "chrome" and "opera" in the respective builds. However, if we should ever drop the Opera-specific builds in the future that won't work anymore. And even until then this information is redundant with addonName which is "adblockpluschrome" and "adblockplusopera" respectively, at the moment. Moreover, other Chromium-based browser (e.g. Yandex.Browser) are mistakenly reported as Chrome.

What to change

Determine info.application at runtime, based on the user agent string.

Change History (1)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.